Re: [PATCH v1 1/1] usb: typec: wcove: Use LE to CPU conversion when accessing msg->header

From: Andy Shevchenko
Date: Mon Jun 07 2021 - 11:29:07 EST


On Thu, May 20, 2021 at 12:26:25PM +0300, Heikki Krogerus wrote:
> On Wed, May 19, 2021 at 11:55:34AM +0300, Andy Shevchenko wrote:
> > As LKP noticed the Sparse is not happy about strict type handling:
> > .../typec/tcpm/wcove.c:380:50: sparse: expected unsigned short [usertype] header
> > .../typec/tcpm/wcove.c:380:50: sparse: got restricted __le16 const [usertype] header
> >
> > Fix this by switching to use pd_header_cnt_le() instead of pd_header_cnt()
> > in the affected code.
> >
> > Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

Thanks!

Greg, should I amend or resend this?

--
With Best Regards,
Andy Shevchenko