Re: [PATCH] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG

From: Greg KH
Date: Fri Jun 04 2021 - 10:48:48 EST


On Fri, Jun 04, 2021 at 10:42:11PM +0800, ricky_wu@xxxxxxxxxxx wrote:
> From: Ricky Wu <ricky_wu@xxxxxxxxxxx>
>
> Divide Realtek Card Reader Group into two different modes
> ASPM_MODE_CFG: 8411 5209 5227 5229 5249 5250
> Change back to use original way to control aspm

What is "aspm"?

> +#define ASPM_MODE_CFG 0x01
> +#define ASPM_MODE_REG 0x02
> + u8 aspm_mode;

Why not use an enum?

thanks,

greg k-h