Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends

From: Linus Walleij
Date: Fri Jun 04 2021 - 09:04:24 EST


On Fri, Jun 4, 2021 at 11:15 AM Daniel Vetter <daniel@xxxxxxxx> wrote:
> On Fri, Jun 04, 2021 at 09:44:59AM +0200, Linus Walleij wrote:
> > On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> >
> > > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> > > pl111 is modular. Update the Kconfig to reflect the need.
> > >
> > > Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")
> >
> > Yeah that doesn't work, thanks for fixing this!
> >
> > > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> >
> > > - depends on VEXPRESS_CONFIG
> > > + depends on ARM || ARM64 || COMPILE_TEST
> > > + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n
> >
> > That's the right solution,
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Since I screwed up already, care to also push this to drm-misc-next?

OK I applied and pushed it!

Yours,
Linus Walleij