Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends

[Linus Walleij]

On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> pl111 is modular. Update the Kconfig to reflect the need.
>
> Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")

Yeah that doesn't work, thanks for fixing this!

> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

> -       depends on VEXPRESS_CONFIG
> +       depends on ARM || ARM64 || COMPILE_TEST
> +       depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n

That's the right solution,
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij