Re: [PATCH v2][next] floppy: Fix fall-through warning for Clang

From: Gustavo A. R. Silva
Date: Thu Jun 03 2021 - 23:03:21 EST




On 5/29/21 01:37, Denis Efremov wrote:
> Hi,
>
> On 5/28/21 11:03 PM, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Link: https://lore.kernel.org/linux-hardening/47bcd36a-6524-348b-e802-0691d1b3c429@xxxxxxxxx/
>> Suggested-by: Jens Axboe <axboe@xxxxxxxxx>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>
> Applied, thanks!
> https://github.com/evdenis/linux-floppy/commit/6eaddb2a2aa3acd0660537f9f6a12785be0ae830
>
> I will send it to Jens with other floppy patches.
> It will be in 5.14

Awesome. :)

Thanks, Denis.
--
Gustavo