Re: [PATCH v2 1/8] Bluetooth: use inclusive language in HCI role

From: Marcel Holtmann
Date: Wed Jun 02 2021 - 15:55:31 EST


Hi Archie,

> This patch replaces some non-inclusive terms based on the appropriate
> language mapping table compiled by the Bluetooth SIG:
> https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
>
> Specifically, these terms are replaced:
> master -> central
> slave -> peripheral
>
> Signed-off-by: Archie Pusaka <apusaka@xxxxxxxxxxxx>
> Reviewed-by: Miao-chen Chou <mcchou@xxxxxxxxxxxx>
>
> ---
>
> Changes in v2:
> * Add details in commit message
>
> include/net/bluetooth/hci.h | 6 +++---
> include/net/bluetooth/hci_core.h | 4 ++--
> net/bluetooth/amp.c | 2 +-
> net/bluetooth/hci_conn.c | 30 +++++++++++++++---------------
> net/bluetooth/hci_core.c | 6 +++---
> net/bluetooth/hci_event.c | 20 ++++++++++----------
> net/bluetooth/l2cap_core.c | 12 ++++++------
> net/bluetooth/smp.c | 20 ++++++++++----------
> 8 files changed, 50 insertions(+), 50 deletions(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index c4b0650fb9ae..18742f4471ff 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -515,7 +515,7 @@ enum {
>
> /* Link modes */
> #define HCI_LM_ACCEPT 0x8000
> -#define HCI_LM_MASTER 0x0001
> +#define HCI_LM_CENTRAL 0x0001
> #define HCI_LM_AUTH 0x0002
> #define HCI_LM_ENCRYPT 0x0004
> #define HCI_LM_TRUSTED 0x0008

this is my fault since I overlooked this one. This is also API. Lets skip this for now.

Regards

Marcel