Re: [PATCH v6 0/3] Rework CPU capacity asymmetry detection

From: Dietmar Eggemann
Date: Wed Jun 02 2021 - 15:10:10 EST


On 27/05/2021 17:38, Beata Michalska wrote:

[...]

> Beata Michalska (3):
> sched/core: Introduce SD_ASYM_CPUCAPACITY_FULL sched_domain flag
> sched/topology: Rework CPU capacity asymmetry detection
> sched/doc: Update the CPU capacity asymmetry bits
>
> Documentation/scheduler/sched-capacity.rst | 6 +-
> Documentation/scheduler/sched-energy.rst | 2 +-
> include/linux/sched/sd_flags.h | 10 ++
> kernel/sched/topology.c | 194 +++++++++++++--------
> 4 files changed, 133 insertions(+), 79 deletions(-)

Looks good to me, even though I would like to see a more compact version
of asym_cpu_capacity_classify(). Details in my response to [PATCH v6 2/3].

Did some level of testing myself and wasn't able to break it.

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>