Re: [PATCH v2 2/4] dt-bindings: arm: scmi property mboxes is not mandatory

From: Sudeep Holla
Date: Wed Jun 02 2021 - 06:41:05 EST


On Fri, May 21, 2021 at 03:40:52PM +0200, Etienne Carriere wrote:
> Since "arm,scmi-smc" compatible support, mboxes property is not mandated.
> This change fixes the DT bindings description accordingly.
>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Etienne Carriere <etienne.carriere@xxxxxxxxxx>
> ---
> Changes since v1:
> - New patch is the series. Addresses mboxes propery description.
> ---
> Documentation/devicetree/bindings/arm/arm,scmi.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> index 667d58e0a659..856d041b397e 100644
> --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt
> +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> @@ -15,10 +15,10 @@ Required properties:
> The scmi node with the following properties shall be under the /firmware/ node.
>
> - compatible : shall be "arm,scmi" or "arm,scmi-smc" for smc/hvc transports
> -- mboxes: List of phandle and mailbox channel specifiers. It should contain
> - exactly one or two mailboxes, one for transmitting messages("tx")
> - and another optional for receiving the notifications("rx") if
> - supported.
> +- mboxes: List of phandle and mailbox channel specifiers. When used, it should
> + contain exactly one or two mailboxes, one for transmitting messages
> + ("tx") and another optional for receiving the notifications("rx") if
> + supported. Mandated by compatible "arm,scmi".

This change is not required with yaml as you can have right schema to reflect
this dependency. I think I already took care of this.

--
Regards,
Sudeep