Re: [PATCH v7 1/2] dt-bindings: hwlock: add sun6i_hwspinlock

From: Rob Herring
Date: Tue Jun 01 2021 - 18:12:40 EST


On Sun, Mar 14, 2021 at 4:30 AM Wilken Gottwalt
<wilken.gottwalt@xxxxxxxxxx> wrote:
>
> Adds documentation on how to use the sun6i_hwspinlock driver for sun6i
> compatible series SoCs.

To repeat what I said on v5: please Cc DT patches to the DT list so
checks run and they get in my queue.

Now this is breaking dt_binding_check in linux-next, so drop, revert or fix it.

>
> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@xxxxxxxxxx>
> ---
> Changes in v7:
> - changed dt documentation to the name of the compatible string
>
> Changes in v6:
> - fixed formating and name issues in dt documentation
>
> Changes in v5:
> - changed binding to earliest known supported SoC sun6i-a31
> - dropped unnecessary entries
>
> Changes in v4:
> - changed binding to sun8i-a33-hwpinlock
> - added changes suggested by Maxime Ripard
>
> Changes in v3:
> - changed symbols from sunxi to sun8i
>
> Changes in v2:
> - fixed memory ranges
> ---
> .../allwinner,sun6i-a31-hwspinlock.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> new file mode 100644
> index 000000000000..733c3d01e56c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
> +
> +maintainers:
> + - Wilken Gottwalt <wilken.gottwalt@xxxxxxxxxx>
> +
> +description:
> + The hardware unit provides semaphores between the ARM cores and the embedded
> + companion core on the SoC.
> +
> +properties:
> + compatible:
> + const: allwinner,sun6i-a31-hwspinlock
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - resets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + hwlock@1c18000 {
> + compatible = "allwinner,sun6i-a31-hwspinlock";
> + reg = <0x01c18000 0x1000>;
> + clocks = <&ccu CLK_BUS_SPINLOCK>;
> + resets = <&ccu RST_BUS_SPINLOCK>;

Error: Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.example.dts:22.28-29
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:402:
Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.example.dt.yaml]
Error 1


You need to include the headers for the defines.



Rob