Re: [PATCH 24/24] usb: typec: ucsi: Fix copy/paste issue for 'ucsi_set_drvdata()'

From: Heikki Krogerus
Date: Wed May 26 2021 - 10:34:22 EST


On Wed, May 26, 2021 at 02:00:37PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/usb/typec/ucsi/ucsi.c:1287: warning: expecting prototype for ucsi_get_drvdata(). Prototype was for ucsi_set_drvdata() instead
>
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
> drivers/usb/typec/ucsi/ucsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index b433169ef6fa4..4e1973fbdf0dc 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1279,7 +1279,7 @@ void *ucsi_get_drvdata(struct ucsi *ucsi)
> EXPORT_SYMBOL_GPL(ucsi_get_drvdata);
>
> /**
> - * ucsi_get_drvdata - Assign private driver data pointer
> + * ucsi_set_drvdata - Assign private driver data pointer
> * @ucsi: UCSI interface
> * @data: Private data pointer
> */
> --
> 2.31.1

--
heikki