Re: [PATCH][RESEND] zram: move backing_dev under macro CONFIG_ZRAM_WRITEBACK

[Minchan Kim]

On Fri, May 21, 2021 at 02:05:44PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2@xxxxxxxxxx>
> 
> backing_dev is never used when not enable CONFIG_ZRAM_WRITEBACK and
> it's introduced from writeback feature. So it's needless also affect
> readability in that case.
> 
> Signed-off-by: Yue Hu <huyue2@xxxxxxxxxx>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Andrew, could you pick?

> ---
>  drivers/block/zram/zram_drv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
> index 419a7e8..6e73dc3 100644
> --- a/drivers/block/zram/zram_drv.h
> +++ b/drivers/block/zram/zram_drv.h
> @@ -113,8 +113,8 @@ struct zram {
>  	 * zram is claimed so open request will be failed
>  	 */
>  	bool claim; /* Protected by bdev->bd_mutex */
> -	struct file *backing_dev;
>  #ifdef CONFIG_ZRAM_WRITEBACK
> +	struct file *backing_dev;
>  	spinlock_t wb_limit_lock;
>  	bool wb_limit_enable;
>  	u64 bd_wb_limit;
> -- 
> 1.9.1
>