Re: [PATCH][next] ACPI: Fix fall-through warning for Clang

From: Rafael J. Wysocki
Date: Fri May 21 2021 - 13:06:03 EST


On Tue, May 18, 2021 at 1:22 AM Gustavo A. R. Silva
<gustavoars@xxxxxxxxxx> wrote:
>
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> fallthrough warning by simply dropping the empty default case at
> the bottom.
>
> This contributes to the ongoing efforts to globally enable
> -Wimplicit-fallthrough for Clang.
>
> Link: https://github.com/KSPP/linux/issues/115
> Suggested-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Link: https://lore.kernel.org/lkml/CAJZ5v0hLYWKX__oZdcCY0D20pNqpw8SkiTPOCNOtpqe--QLp4Q@xxxxxxxxxxxxxx/
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> ---
> drivers/acpi/sbshc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c
> index 53c2862c4c75..5c021c3b81d9 100644
> --- a/drivers/acpi/sbshc.c
> +++ b/drivers/acpi/sbshc.c
> @@ -231,7 +231,6 @@ static int smbus_alarm(void *context)
> case ACPI_SBS_BATTERY:
> acpi_os_execute(OSL_NOTIFY_HANDLER,
> acpi_smbus_callback, hc);
> - default:;
> }
> mutex_unlock(&hc->lock);
> return 0;
> --

Applied as 5.14 material, thanks!