Re: [PATCH v2 3/7] drivers: firmware: psci: Use _BITUL() macro in UAPI headers

From: Mark Rutland
Date: Fri May 21 2021 - 09:26:00 EST


On Fri, May 21, 2021 at 01:58:44AM -0700, Joe Richey wrote:
> From: Joe Richey <joerichey@xxxxxxxxxx>
>
> Replace BIT() in psci's UPAI header with _BITUL(). BIT() is not defined
> in the UAPI headers and its usage may cause userspace build errors.
>
> Fixes: 60dd1ead65e8 ("drivers: firmware: psci: Announce support for OS initiated suspend mode")
> Signed-off-by: Joe Richey <joerichey@xxxxxxxxxx>

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Mark.

> ---
> include/uapi/linux/psci.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/psci.h b/include/uapi/linux/psci.h
> index 2fcad1dd0b0e..87afdeb95096 100644
> --- a/include/uapi/linux/psci.h
> +++ b/include/uapi/linux/psci.h
> @@ -12,6 +12,8 @@
> #ifndef _UAPI_LINUX_PSCI_H
> #define _UAPI_LINUX_PSCI_H
>
> +#include <linux/const.h>
> +
> /*
> * PSCI v0.1 interface
> *
> @@ -100,7 +102,7 @@
> #define PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK \
> (0x1 << PSCI_1_0_FEATURES_CPU_SUSPEND_PF_SHIFT)
>
> -#define PSCI_1_0_OS_INITIATED BIT(0)
> +#define PSCI_1_0_OS_INITIATED _BITUL(0)
> #define PSCI_1_0_SUSPEND_MODE_PC 0
> #define PSCI_1_0_SUSPEND_MODE_OSI 1
>
> --
> 2.31.1
>