Re: [PATCH v2] spi: Don't have controller clean up spi device before driver unbind

From: Lukas Wunner
Date: Fri May 21 2021 - 01:09:51 EST


On Wed, May 05, 2021 at 09:47:34AM -0700, Saravana Kannan wrote:
> When a spi device is unregistered and triggers a driver unbind, the
> driver might need to access the spi device. So, don't have the
> controller clean up the spi device before the driver is unbound. Clean
> up the spi device after the driver is unbound.
>
> Fixes: c7299fea6769 ("spi: Fix spi device unregister flow")
> Reported-by: Lukas Wunner <lukas@xxxxxxxxx>
> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> ---
>
> v1->v2:
> - Made the clean up more symmetric.
>
> Lukas,
>
> Can you test this one your end to make sure you don't have issues
> anymore?

Tested-by: Lukas Wunner <lukas@xxxxxxxxx>

My apologies for the delay, yesterday I was finally able to set up a RasPi
in my home office and test the patch. I'm not seeing any issues when
unloading/reloading the SPI controller module, so this LGTM.

Thanks,

Lukas