Re: [RFC v2 27/32] x86/tdx: Exclude Shared bit from __PHYSICAL_MASK

From: Andi Kleen
Date: Thu May 20 2021 - 19:25:20 EST



On 5/20/2021 2:28 PM, Kuppuswamy, Sathyanarayanan wrote:


On 5/20/21 2:23 PM, Dave Hansen wrote:
Sathya has even mis-typed "tdx" instead of "tdg" this in his own
changelogs up to this point.  That massively weakens the argument that
"tdg" is a good idea.

It is not a typo. But when we did the initial rename from "tdx_" -> "tdg_",
somehow I missed the change log change. That's why I am bit reluctant
to go for another rename (since we have scan change log, comments and code)
in all the patches.


Yes I agree. If there's another rename it should be after a full review by all the maintainers. If there is still consensus that a rename is needed then it can be done then.

And we'll just hope that Sean's brain will get used to tdg_ by then.


-Andi