Re: [PATCH 10/38] drm/amd/amdgpu/amdgpu_ids: Correct some function name disparity

[Alex Deucher]

Applied.  Thanks!

Alex

On Thu, May 20, 2021 at 8:04 AM Christian König
<christian.koenig@xxxxxxx> wrote:
>
> Am 20.05.21 um 14:02 schrieb Lee Jones:
> > Fixes the following W=1 kernel build warning(s):
> >
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:200: warning: expecting prototype for amdgpu_vm_grab_idle(). Prototype was for amdgpu_vmid_grab_idle() instead
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:272: warning: expecting prototype for amdgpu_vm_grab_reserved(). Prototype was for amdgpu_vmid_grab_reserved() instead
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:337: warning: expecting prototype for amdgpu_vm_grab_used(). Prototype was for amdgpu_vmid_grab_used() instead
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:410: warning: expecting prototype for amdgpu_vm_grab_id(). Prototype was for amdgpu_vmid_grab() instead
> >
> > Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> > Cc: "Christian König" <christian.koenig@xxxxxxx>
> > Cc: David Airlie <airlied@xxxxxxxx>
> > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > Cc: linux-media@xxxxxxxxxxxxxxx
> > Cc: linaro-mm-sig@xxxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> Reviewed-by: Christian König <christian.koenig@xxxxxxx>
>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> > index b4971e90b98cf..c7f3aae23c625 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> > @@ -183,7 +183,7 @@ bool amdgpu_vmid_had_gpu_reset(struct amdgpu_device *adev,
> >   }
> >
> >   /**
> > - * amdgpu_vm_grab_idle - grab idle VMID
> > + * amdgpu_vmid_grab_idle - grab idle VMID
> >    *
> >    * @vm: vm to allocate id for
> >    * @ring: ring we want to submit job to
> > @@ -256,7 +256,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,
> >   }
> >
> >   /**
> > - * amdgpu_vm_grab_reserved - try to assign reserved VMID
> > + * amdgpu_vmid_grab_reserved - try to assign reserved VMID
> >    *
> >    * @vm: vm to allocate id for
> >    * @ring: ring we want to submit job to
> > @@ -325,7 +325,7 @@ static int amdgpu_vmid_grab_reserved(struct amdgpu_vm *vm,
> >   }
> >
> >   /**
> > - * amdgpu_vm_grab_used - try to reuse a VMID
> > + * amdgpu_vmid_grab_used - try to reuse a VMID
> >    *
> >    * @vm: vm to allocate id for
> >    * @ring: ring we want to submit job to
> > @@ -397,7 +397,7 @@ static int amdgpu_vmid_grab_used(struct amdgpu_vm *vm,
> >   }
> >
> >   /**
> > - * amdgpu_vm_grab_id - allocate the next free VMID
> > + * amdgpu_vmid_grab - allocate the next free VMID
> >    *
> >    * @vm: vm to allocate id for
> >    * @ring: ring we want to submit job to
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx