Re: [PATCH 2/2] mtd: partitions: redboot: fix style issues

From: Linus Walleij
Date: Thu May 20 2021 - 12:00:21 EST


On Thu, May 20, 2021 at 5:36 PM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> Linus Walleij <linus.walleij@xxxxxxxxxx> wrote on Thu, 20 May 2021
> 17:24:26 +0200:
> > On Thu, May 20, 2021 at 1:49 PM Corentin Labbe <clabbe@xxxxxxxxxxxx> wrote:
> >
> > > This patch fixes easy checkpatch issues.
> > >
> > > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>
> > (...)
> > > - uint32_t flash_base; // Address within FLASH of image
> > (...)
> > > + u32 flash_base; // Address within FLASH of image
> >
> > Does checkpatch complain about this? At one point the MTD maintainer
> > disliked the u32/u16/u8 types and explicitly wanted to use the C
> > standard library types, and it's the kind of eccentric maintainer
> > deviations we accommodate for.
>
> I suppose this happened quite some time ago? :)
>
> I've never heard Richard nor Boris complaining about it, nor will I.

Yes that was a specific David Woodhouse preference.
I'm too old!

Yours,
Linus Walleij