Re: [PATCH 5.4 020/141] ip6_vti: proper dev_{hold|put} in ndo_[un]init methods

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Thu May 20 2021 - 04:31:27 EST


On Thu, May 20, 2021 at 07:55:49AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
> > I do not understand, what needs to be done here?
>
> Sorry, email formatting got somehow messed up.
>
> Please cherry-pick this to 5.4.y:
>
> commit 0d7a7b2014b1a499a0fe24c9f3063d7856b5aaaf
> Author: Eric Dumazet <edumazet@xxxxxxxxxx>
> Date: Wed Mar 31 14:38:11 2021 -0700
>
> ipv6: remove extra dev_hold() for fallback tunnels
>
>
> And these:
>
> Fixes: 48bb5697269a ("ip6_tunnel: sit: proper dev_{hold|put} in
> ndo_[un]init methods")
> Fixes: 6289a98f0817 ("sit: proper dev_{hold|put} in ndo_[un]init
> methods")
> Fixes: 7f700334be9a ("ip6_gre: proper dev_{hold|put} in ndo_[un]init
> methods")

Ah, that makes sense. Tricky as the "Fixes:" tag for those other
commits were not backported because they pointed to a feature added to
debug these issues :)

now queued up.

greg k-h