Re: [PATCH 1/2] dt-bindings: rng: mediatek: convert to yaml schema

From: Rob Herring
Date: Wed May 19 2021 - 18:04:27 EST


On Tue, May 18, 2021 at 01:22:49PM +0200, Fabien Parent wrote:
> Convert the RNG binding for MediaTek to use YAML schema.
>
> Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/rng/mtk-rng.txt | 22 --------
> .../devicetree/bindings/rng/mtk-rng.yaml | 53 +++++++++++++++++++
> 2 files changed, 53 insertions(+), 22 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/rng/mtk-rng.txt
> create mode 100644 Documentation/devicetree/bindings/rng/mtk-rng.yaml
>
> diff --git a/Documentation/devicetree/bindings/rng/mtk-rng.txt b/Documentation/devicetree/bindings/rng/mtk-rng.txt
> deleted file mode 100644
> index dfdcb5cd2ea8..000000000000
> --- a/Documentation/devicetree/bindings/rng/mtk-rng.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -Device-Tree bindings for Mediatek random number generator
> -found in MediaTek SoC family
> -
> -Required properties:
> -- compatible : Should be
> - "mediatek,mt7622-rng", "mediatek,mt7623-rng" : for MT7622
> - "mediatek,mt7629-rng", "mediatek,mt7623-rng" : for MT7629
> - "mediatek,mt7623-rng" : for MT7623
> - "mediatek,mt8516-rng", "mediatek,mt7623-rng" : for MT8516
> -- clocks : list of clock specifiers, corresponding to
> - entries in clock-names property;
> -- clock-names : Should contain "rng" entries;
> -- reg : Specifies base physical address and size of the registers
> -
> -Example:
> -
> -rng: rng@1020f000 {
> - compatible = "mediatek,mt7623-rng";
> - reg = <0 0x1020f000 0 0x1000>;
> - clocks = <&infracfg CLK_INFRA_TRNG>;
> - clock-names = "rng";
> -};
> diff --git a/Documentation/devicetree/bindings/rng/mtk-rng.yaml b/Documentation/devicetree/bindings/rng/mtk-rng.yaml
> new file mode 100644
> index 000000000000..d9731f0ae47d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rng/mtk-rng.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/rng/mtk-rng.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> +
> +title: MediaTek Random number generator
> +
> +maintainers:
> + - Sean Wang <sean.wang@xxxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - mediatek,mt7623-rng
> + - items:
> + - const: mediatek,mt7622-rng
> + - const: mediatek,mt7623-rng
> + - items:
> + - const: mediatek,mt7629-rng
> + - const: mediatek,mt7623-rng
> + - items:
> + - const: mediatek,mt8516-rng
> + - const: mediatek,mt7623-rng

The last 3 can be:

- items:
- enum:
- mediatek,mt7622-rng
- mediatek,mt7629-rng
- mediatek,mt8516-rng
- const: mediatek,mt7623-rng

> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: rng
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt2701-clk.h>
> + rng: rng@1020f000 {
> + compatible = "mediatek,mt7623-rng";
> + reg = <0x1020f000 0x1000>;
> + clocks = <&infracfg CLK_INFRA_TRNG>;
> + clock-names = "rng";
> + };
> --
> 2.31.1
>