Re: [PATCH 5/5] mm/swap: simplify the code of find_get_incore_page()

From: Matthew Wilcox
Date: Tue May 18 2021 - 17:35:20 EST


On Tue, May 18, 2021 at 02:13:04PM -0700, Andrew Morton wrote:
> On Tue, 18 May 2021 15:33:54 +0100 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> > On Tue, May 18, 2021 at 09:53:52PM +0800, Miaohe Lin wrote:
> > > pagecache_get_page() can do find_subpage() for us if we do not specify
> > > FGP_HEAD. No functional change intended.
> >
> > Please, no. This interferes with the folio work.
>
> In what way? Can't the folio patches simply revert this or suitably
> alter it?

Of course, it's just software. Anything can just be modified. I don't
see the point of putting in a cleanup patch that creates a conflict with
important work.