Re: [PATCH 1/2] uio_hv_generic: Fix a memory leak in error handling paths

[Christophe JAILLET]

Le 15/05/2021 à 18:09, Wei Liu a écrit :
> On Tue, May 11, 2021 at 08:18:23PM +0200, Christophe JAILLET wrote:
> > Le 11/05/2021 à 11:52, Wei Liu a écrit :
> > > > Before commit cdfa835c6e5e, the 'vfree' were done unconditionally
> > > > in 'hv_uio_cleanup()'.
> > > > So, another way for fixing the potential leak is to modify
> > > > 'hv_uio_cleanup()' and revert to the previous behavior.
> > >
> > > I think this is cleaner.
> >
> > Agreed
>
> Stephen, ping?
>
> If I don't hear back from you, I think Christophe should move ahead with
> modifying hv_uio_cleanup.
>
> Wei.

Hi,
just for your information, it has already been picked by Greg KH (see [1]).
If the cleaner solution is preferred, it will be built on top of this patch.

CJ

[1]: 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/uio/uio_hv_generic.c?id=3ee098f96b8b6c1a98f7f97915f8873164e6af9d