Re: [PATCH RESEND][next] xfrm: Fix fall-through warnings for Clang

From: Gustavo A. R. Silva
Date: Mon May 17 2021 - 21:33:54 EST


Hi all,

If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:08, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 3/5/21 03:23, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>> ---
>> net/xfrm/xfrm_interface.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
>> index 8831f5a9e992..41de46b5ffa9 100644
>> --- a/net/xfrm/xfrm_interface.c
>> +++ b/net/xfrm/xfrm_interface.c
>> @@ -432,6 +432,7 @@ static int xfrmi4_err(struct sk_buff *skb, u32 info)
>> case ICMP_DEST_UNREACH:
>> if (icmp_hdr(skb)->code != ICMP_FRAG_NEEDED)
>> return 0;
>> + break;
>> case ICMP_REDIRECT:
>> break;
>> default:
>>