Re: [PATCH v2][next] afs: Fix fall-through warnings for Clang

From: Gustavo A. R. Silva
Date: Mon May 17 2021 - 20:32:56 EST




On 4/21/21 18:03, Jeffrey E Altman wrote:
> On 4/20/2021 5:16 PM, Gustavo A. R. Silva (gustavoars@xxxxxxxxxx) wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
>> warnings by explicitly adding multiple fallthrough pseudo-keywords
>> in places where the code is intended to fall through to the next
>> case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>> ---
>> Changes in v2:
>>   - Place blank line after the fallthrough markings, not before.
>>     Link: https://lore.kernel.org/linux-hardening/748935.1606147853@xxxxxxxxxxxxxxxxxxxxxx/
>
> This change looks good to me.
>
> Reviewed-by: Jeffrey Altman <jaltman@xxxxxxxxxxxx>

Thanks, Jeffrey.

Could someone take this, please?

Thanks
--
Gustavo