Re: [PATCH 1/2] KVM: x86: Invert APICv/AVIC enablement check

From: Jim Mattson
Date: Mon May 17 2021 - 17:10:03 EST


On Mon, May 17, 2021 at 2:03 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> On Thu, May 13, 2021, Vitaly Kuznetsov wrote:
> > Currently, APICv/AVIC enablement is global ('enable_apicv' module parameter
> > for Intel, 'avic' module parameter for AMD) but there's no way to check
> > it from vendor-neutral code. Add 'apicv_supported()' to kvm_x86_ops and
> > invert kvm_apicv_init() (which now doesn't need to be called from arch-
> > specific code).
>
> Rather than add a new hook, just move the variable to x86.c, and export it so
> that VMX and SVM can give it different module names. The only hiccup is that
> avic is off by default, but I don't see why that can't be changed.

See https://www.spinics.net/lists/kvm/msg208722.html.