Re: [PATCH 1/2] drm: bridge: it66121: fix an error code in it66121_probe()

From: Neil Armstrong
Date: Mon May 17 2021 - 04:42:45 EST


On 15/05/2021 11:50, Dan Carpenter wrote:
> This code is passing the wrong variable to PTR_ERR() so it doesn't
> return the correct error code.
>
> Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/ite-it66121.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index d8a60691fd32..6980c9801d0d 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -943,7 +943,7 @@ static int it66121_probe(struct i2c_client *client,
> ctx->regmap = devm_regmap_init_i2c(client, &it66121_regmap_config);
> if (IS_ERR(ctx->regmap)) {
> ite66121_power_off(ctx);
> - return PTR_ERR(ctx);
> + return PTR_ERR(ctx->regmap);
> }
>
> regmap_read(ctx->regmap, IT66121_VENDOR_ID0_REG, &vendor_ids[0]);
>

Thanks !

Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>

Applying to drm-misc-fixes