Re: [PATCH] MIPS: alchemy: xxs1500: add gpio-au1000.h header file

From: Manuel Lauss
Date: Mon May 17 2021 - 03:50:36 EST


Hello,

On Mon, May 17, 2021 at 2:01 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> board-xxs1500.c references 2 functions without declaring them, so add
> the header file to placate the build.
>
> ../arch/mips/alchemy/board-xxs1500.c: In function 'board_setup':
> ../arch/mips/alchemy/board-xxs1500.c:56:2: error: implicit declaration of function 'alchemy_gpio1_input_enable' [-Werror=implicit-function-declaration]
> 56 | alchemy_gpio1_input_enable();
> ../arch/mips/alchemy/board-xxs1500.c:57:2: error: implicit declaration of function 'alchemy_gpio2_enable'; did you mean 'alchemy_uart_enable'? [-Werror=implicit-function-declaration]
> 57 | alchemy_gpio2_enable();
>
> Fixes: 8e026910fcd4 ("MIPS: Alchemy: merge GPR/MTX-1/XXS1500 board code into single files")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxxx
> Cc: Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> ---
> arch/mips/alchemy/board-xxs1500.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210514.orig/arch/mips/alchemy/board-xxs1500.c
> +++ linux-next-20210514/arch/mips/alchemy/board-xxs1500.c
> @@ -18,6 +18,7 @@
> #include <asm/reboot.h>
> #include <asm/setup.h>
> #include <asm/mach-au1x00/au1000.h>
> +#include <asm/mach-au1x00/gpio-au1000.h>

Acked-by: Manuel Lauss <manuel.lauss@xxxxxxxxx>

Thank you!
Manuel