Re: [PATCH v19 3/8] set_memory: allow set_direct_map_*_noflush() for multiple pages

From: Mike Rapoport
Date: Sun May 16 2021 - 03:15:00 EST


On Fri, May 14, 2021 at 10:43:29AM +0200, David Hildenbrand wrote:
> On 13.05.21 20:47, Mike Rapoport wrote:
> > From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> >
> > The underlying implementations of set_direct_map_invalid_noflush() and
> > set_direct_map_default_noflush() allow updating multiple contiguous pages
> > at once.
> >
> > Add numpages parameter to set_direct_map_*_noflush() to expose this
> > ability with these APIs.
>
> AFAIKs, your patch #5 right now only calls it with 1 page, do we need this
> change at all? Feels like a leftover from older versions to me where we
> could have had more than a single page.

Right, will drop it.

--
Sincerely yours,
Mike.