Re: [PATCH 0/3] xen: remove some checks for always present Xen features

From: Peter Zijlstra
Date: Mon May 10 2021 - 08:50:49 EST


On Mon, May 10, 2021 at 09:34:18AM +0200, Juergen Gross wrote:
> On 22.04.21 17:10, Juergen Gross wrote:
> > Some features of Xen can be assumed to be always present, so add a
> > central check to verify this being true and remove the other checks.
> >
> > Juergen Gross (3):
> > xen: check required Xen features
> > xen: assume XENFEAT_mmu_pt_update_preserve_ad being set for pv guests
> > xen: assume XENFEAT_gnttab_map_avail_bits being set for pv guests
> >
> > arch/x86/xen/enlighten_pv.c | 12 ++----------
> > arch/x86/xen/mmu_pv.c | 4 ++--
> > drivers/xen/features.c | 18 ++++++++++++++++++
> > drivers/xen/gntdev.c | 36 ++----------------------------------
> > 4 files changed, 24 insertions(+), 46 deletions(-)
> >
>
> Could I please get some feedback on this series?

I'm obviously in favour, but given I'm not an actual Xen user that might
not be worth much, still:

Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>