Re: [PATCH] nvme: fix unused variable warning

From: Bjorn Helgaas
Date: Fri Apr 30 2021 - 13:57:29 EST


On Wed, Apr 21, 2021 at 04:04:20PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The function was introduced with a variable that is never referenced:
>
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:25: warning: unused variable 'rdev' [-Wunused-variable]
>
> Fixes: 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")

I guess this refers to https://lore.kernel.org/linux-nvme/1618458725-17164-1-git-send-email-Prike.Liang@xxxxxxx/

But I don't know what the SHA1 means; I can't find it in linux-next or
my tree.

> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/pci/quirks.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 2e24dced699a..c86ede081534 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -309,8 +309,6 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8151_0, quirk_nopci
>
> static void quirk_amd_nvme_fixup(struct pci_dev *dev)
> {
> - struct pci_dev *rdev;
> -
> dev->dev_flags |= PCI_DEV_FLAGS_AMD_NVME_SIMPLE_SUSPEND;
> pci_info(dev, "AMD simple suspend opt enabled\n");
>
> --
> 2.29.2
>