Re: [PATCH net-next v1 1/1] net: selftest: provide option to disable generic selftests

From: Andrew Lunn
Date: Fri Apr 30 2021 - 12:23:36 EST


> > Thanks for the patch/option. But I think it should just default to n,
> > not PHYLIB.
>
> It should be enabled by default for every device supporting this kind of
> selftests.

I agree.

I still wonder if there is confusion about self test here. Maybe
putting ethtool into the description will help people understand it
has nothing to do with the kernel self test infrastructure and kernel
self testing.

Andrew