Re: [PATCH] IB/qib: Remove redundant assignment to ret

From: Jason Gunthorpe
Date: Fri Apr 30 2021 - 10:28:52 EST


On Thu, Apr 29, 2021 at 06:42:20PM +0800, Yang Li wrote:
> Variable 'ret' is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed
>
> Clean up the following clang-analyzer warning:
>
> drivers/infiniband/hw/qib/qib_sd7220.c:690:2: warning: Value stored to
> 'ret' is never read [clang-analyzer-deadcode.DeadStores]
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/qib/qib_sd7220.c | 1 -
> 1 file changed, 1 deletion(-)

Applied to for-next, thanks

Jason