Re: [PATCH] ata: ahci_sunxi: Disable DIPM

[Sergei Shtylyov]

Hello!

On 28.04.2021 2:05, Timo Sigurdsson wrote:

> DIPM is unsupported or broken on sunxi. Trying to enable the power
> management policy med_power_with_dipm on an Allwinner A20 SoC based board
> leads to immediate I/O errors and the attached SATA disk disappears from
> the /dev filesystem. A reset (power cycle) is required to make the SATA
> controller or disk work again. The A10 and A20 SoC data sheets and manuals
> don't mention DIPM at all [1], so it's fair to assume that it's simply not
> supported. But even if it were, it should be considered broken and best be
                            ^ was

> disabled in the ahci_sunxi driver.
>
> Fixes: c5754b5220f0 ("ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform")

   The "Fixes:" tag should immediately precede the signoff tag...

> [1] https://github.com/allwinner-zh/documents/tree/master/

   And this line should be immediately after the patch description.

> Signed-off-by: Timo Sigurdsson <public_timo.s@xxxxxxxxxxxxxx>
> Tested-by: Timo Sigurdsson <public_timo.s@xxxxxxxxxxxxxx>
[...]

MBR, Sergei