Re: [PATCH v10 clocksource 1/7] clocksource: Provide module parameters to inject delays in watchdog

From: Paul E. McKenney
Date: Mon Apr 26 2021 - 14:24:36 EST


On Mon, Apr 26, 2021 at 10:56:27AM -0700, Andi Kleen wrote:
> > ------------------------------------------------------------------------
> >
> > - module parameters
> >
> > If the scope of the fault injection capability is limited to a
> > single kernel module, it is better to provide module parameters to
> > configure the fault attributes.
> >
> > ------------------------------------------------------------------------
> >
> > And in this case, the fault injection capability is in fact limited to
> > kernel/clocksource.c.
>
>
> I disagree with this recommendation because it prevents fuzzer coverage.
>
> Much better to have an uniform interface that can be automatically
> explored.

The permissions for these module parameters is 0644, so there is no
reason why the fuzzers cannot use them via sysfs.

Thanx, Paul