Re: [net-next, v2, 3/7] net: dsa: free skb->cb usage in core driver

From: Richard Cochran
Date: Mon Apr 26 2021 - 09:39:00 EST


On Mon, Apr 26, 2021 at 05:37:58PM +0800, Yangbo Lu wrote:
> @@ -624,7 +623,7 @@ static netdev_tx_t dsa_slave_xmit(struct sk_buff *skb, struct net_device *dev)
>
> dev_sw_netstats_tx_add(dev, 1, skb->len);
>
> - DSA_SKB_CB(skb)->clone = NULL;
> + memset(skb->cb, 0, 48);

Replace hard coded 48 with sizeof() please.

Thanks,
Richard