Re: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG.

From: Thomas Bogendoerfer
Date: Mon Apr 26 2021 - 09:01:40 EST


On Sat, Apr 24, 2021 at 08:59:50AM -0700, zhouchuangao wrote:
> BUG_ON uses unlikely in if(), it can be optimized at compile time.
>
> Usually, the condition in if() is not satisfied. In my opinion,
> this can improve the efficiency of the multi-stage pipeline.
>
> Signed-off-by: zhouchuangao <zhouchuangao@xxxxxxxx>
> ---
> arch/mips/bcm63xx/gpio.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]