Re: [PATCH v2 net-next 1/9] dt-bindings: net: dsa: dt bindings for microchip lan937x

From: Prasanna Vengateshan
Date: Mon Apr 26 2021 - 00:05:14 EST


On Thu, 2021-04-22 at 12:38 -0500, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Thu, Apr 22, 2021 at 03:12:49PM +0530, Prasanna Vengateshan wrote:
> > Documentation in .yaml format and updates to the MAINTAINERS
> > Also 'make dt_binding_check' is passed
> >
> > Signed-off-by: Prasanna Vengateshan <prasanna.vengateshan@xxxxxxxxxxxxx>
> > ---
> > .../bindings/net/dsa/microchip,lan937x.yaml | 142 ++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 143 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml
> > b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml
> > new file mode 100644
> > index 000000000000..22128a52d699
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml
> > @@ -0,0 +1,142 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/dsa/microchip,lan937x.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: LAN937x Ethernet Switch Series Tree Bindings
> > +
> > +maintainers:
> > + - UNGLinuxDriver@xxxxxxxxxxxxx
> > +
> > +allOf:
> > + - $ref: dsa.yaml#
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - microchip,lan9370
> > + - microchip,lan9371
> > + - microchip,lan9372
> > + - microchip,lan9373
> > + - microchip,lan9374
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + spi-max-frequency:
> > + maximum: 50000000
> > +
> > + reset-gpios:
> > + description: Optional gpio specifier for a reset line
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + //Ethernet switch connected via spi to the host
>
> If this is on SPI, why is it not under the spi bus node?
Thanks for reviewing the patch. I will move this comment to above the spi node.

>
> > + ethernet {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
> > +
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + lan9374: switch@0 {
> > + compatible = "microchip,lan9374";
> > + reg = <0>;
> > +
> > + spi-max-frequency = <44000000>;
> > +
> > + ethernet-ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@0 {
> > + reg = <0>;
> > + label = "lan1";
> > + phy-handle = <&t1phy0>;
> > + };
> > + port@1 {
> > + reg = <1>;
> > + label = "lan2";
> > + phy-handle = <&t1phy1>;
> > + };
> > + port@2 {
> > + reg = <2>;
> > + label = "lan4";
> > + phy-handle = <&t1phy2>;
> > + };
> > + port@3 {
> > + reg = <3>;
> > + label = "lan6";
> > + phy-handle = <&t1phy3>;
> > + };
> > + port@4 {
> > + reg = <4>;
> > + phy-mode = "rgmii";
> > + ethernet = <&ethernet>;
>
> You are missing 'ethernet' label.
This is the cpu port and label is not used anywhere. i received this feedback in
last patch version.

>
> >
> > + };
> > + };
> > +
> > + mdio {
> > + compatible = "microchip,lan937x-mdio";
>
> You can just drop this to make the example pass. Or convert that binding
> to schema.
Okay, will remove in the next revision. Also i have received an alternate
suggestion in the other patch to avoid usage of compatible string.

>
> >
> > --
> > 2.27.0
> >