Re: [PATCH v2] pwm: Introduce single-PWM of_xlate function

[Uwe Kleine-König]

Hello,

On Fri, Apr 23, 2021 at 04:33:04PM -0500, Bjorn Andersson wrote:
> The existing pxa driver and the upcoming addition of PWM support in the
> TI sn565dsi86 DSI/eDP bridge driver both has a single PWM channel and
> thereby a need for a of_xlate function with the period as its single
> argument.
> 
> Introduce a common helper function in the core that can be used as
> of_xlate by such drivers and migrate the pxa driver to use this.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

I'm OK with the idea as such. I'd like to see the semantic expanded a
bit however such that the function can parse

	pwms = <&mypwm 50000>;

and also

	pwms = <&mypwm 500000 PWM_POLARITY_INVERTED>;

. You suggetion only covers the former.

See
https://lore.kernel.org/r/20210315111124.2475274-2-u.kleine-koenig@xxxxxxxxxxxxxx
for my first attempt to unify of_pwm_xlate_with_flags and
of_pwm_simple_xlate accordingly.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature