Re: [PATCH] tools/memory-model: Correct the name of smp_mb__after_spinlock()

From: Paul E. McKenney
Date: Sat Apr 24 2021 - 00:28:47 EST


On Fri, Apr 23, 2021 at 05:25:09PM -0700, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx>
>
> This was missing one of the double _s. I only found it because I
> mis-typed the name myself.
>
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx>

Good catch, and thank you, but Björn Töpel beat you to it.

dce310f2e546 ("tools/memory-model: Fix smp_mb__after_spinlock() spelling")

This one is queued in the -rcu tree for the v5.14 merge window.

But please keep the fixes coming!

Thanx, Paul

> ---
> tools/memory-model/Documentation/explanation.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
> index f9d610d5a1a4..5d72f3112e56 100644
> --- a/tools/memory-model/Documentation/explanation.txt
> +++ b/tools/memory-model/Documentation/explanation.txt
> @@ -2510,7 +2510,7 @@ they behave as follows:
> smp_mb__after_atomic() orders po-earlier atomic updates and
> the events preceding them against all po-later events;
>
> - smp_mb_after_spinlock() orders po-earlier lock acquisition
> + smp_mb__after_spinlock() orders po-earlier lock acquisition
> events and the events preceding them against all po-later
> events.
>
> --
> 2.31.1.498.g6c1eba8ee3d-goog
>