Re: [PATCH] Revert "MIPS: make userspace mapping young by default".

From: Thomas Bogendoerfer
Date: Fri Apr 23 2021 - 10:57:20 EST


On Tue, Apr 20, 2021 at 10:03:01PM +0800, Zhou Yanjie wrote:
> Sorry for my carelessness, the log in the previous email was wrong, please
> check the log in this email.
>
> [   53.684067] --- pte 1 = 07698685

any chance to print the virtual address to this pte ?

> [   53.687376] --- pte 3 = 07698685
> [   53.737175] --- pte 1 = 07699685
> [   53.740412] --- pte 3 = 07699685
> [   53.744064] --- pte 1 = 076c3685
> [..]

could you print PTE, which faults ? And what is mapped there ?


so far I haven't seen any ill-effects of the (bisected ?) patch.
The problem I have with reverting is that IMHO we re-introduce the bug,
which this patch fixed.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]