Re: [PATCH] bnx2x: Fix potential infinite loop

[David Miller]

From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Wed,  7 Apr 2021 15:28:02 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The for_each_tx_queue loop iterates with a u8 loop counter i and
> compares this with the loop upper limit of bp->num_queues that
> is an int type.  There is a potential infinite loop if bp->num_queues
> is larger than the u8 loop counter. Fix this by making the loop
> counter the same type as bp->num_queues.
> 
> Addresses-Coverity: ("Infinite loop")
> Fixes: ad5afc89365e ("bnx2x: Separate VF and PF logic")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Please show how num_queues can take on a value larger than 255.

Thank you.