Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

[Dmitry Osipenko]

07.04.2021 04:25, Sowjanya Komatineni пишет:
> +	if (!tegra->pdev->dev.pm_domain) {
> +		ret = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_SATA,
> +							tegra->sata_clk,
> +							tegra->sata_rst);
> +		if (ret)
> +			goto disable_regulators;
> +	}
>  

Hi,

Why you haven't added condition for tegra_powergate_power_off()? I think
it should break GENPD and legacy PD API isn't not supported by T186 at all.

I'm also not sure whether the power up/down sequence is correct using GENPD.

Moreover the driver doesn't support runtime PM, so GENPD should be
always off?