Re: [PATCH RFC net 1/2] net: dsa: lantiq_gswip: Don't use PHY auto polling

From: Martin Blumenstingl
Date: Wed Apr 07 2021 - 14:57:25 EST


Hi Andrew,

On Wed, Apr 7, 2021 at 2:25 AM Andrew Lunn <andrew@xxxxxxx> wrote:
[...]
> Having the MAC polling the PHY is pretty much always a bad idea.
>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
thanks for reviewing this!

For my own curiosity: is there a "recommended" way where to configure
link up/down, speed, duplex and flow control? currently I have the
logic in both, .phylink_mac_config and .phylink_mac_link_up.


Thank you!
Martin