Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header

From: Andy Shevchenko
Date: Wed Apr 07 2021 - 13:11:00 EST


On Wed, Apr 07, 2021 at 10:43:53AM -0600, Jens Axboe wrote:
> On 4/7/21 10:27 AM, Andy Shevchenko wrote:
> > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote:
> >> On 4/7/21 10:03 AM, Andy Shevchenko wrote:
> >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote:
> >
> > ...
> >
> >>>> All errors (new ones prefixed by >>):
> >>>
> >>> Thanks, we need to include bits.h.
> >>> (It passed my simple build, but appears I have no such driver included)
> >>>
> >>> Jens, I saw your message, should I send a follow up fix, or a v2?
> >>
> >> Let's just drop it, not worth it for the risk imho.
> >
> > Does it mean I may try again in next cycle?
> >
> > Because kernel.h inclusion seems to me too wrong there.
>
> I don't mind taking it, but not on a hunch. If you send something
> that has been thought about and went through full compilation, then
> you can resend it.

Got it! I think allyesconfig would serve a good job.

--
With Best Regards,
Andy Shevchenko