Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h

From: kernel test robot
Date: Wed Apr 07 2021 - 12:22:06 EST

Next message:
Previous
In reply
Messages

Hi Mitali,

Thank you for the
[auto build test ERROR
url: #
If you fix the issue, Reported-by: kernel
All errors (new ones
In file included drivers/staging/rtl8712/ >> drivers/staging 144 | INIT_WORK(& | include/linux/workqueue.h:237:20: 237 | (_work)->func | ^~~~~
drivers/staging/rtl8712/ 144 | INIT_WORK(& | ^~~~~~~~~
drivers/staging/rtl8712/ 144 | INIT_WORK(& | include/linux/workqueue.h:237:20: 237 | (_work)->func | ^~~~~
drivers/staging/rtl8712/ 144 | INIT_WORK(& | ^~~~~~~~~

vim +144 drivers/staging/rt
2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 534c4acd1d4594 James 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 534c4acd1d4594 James 534c4acd1d4594 James 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger ed5d2eaf5f5d59 Nishka Dasgupta 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 09b080f73a4191 Vijai Kumar K 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger d7e6ede6acd4fb Aiman Najjar 09b080f73a4191 Vijai Kumar K 09b080f73a4191 Vijai Kumar K 2865d42c78a912 Larry Finger a77a40cf8b42b3 Bhagyashri Dighole d7e6ede6acd4fb Aiman Najjar d7e6ede6acd4fb Aiman Najjar 9155c92463ecbb Bhumika Goyal 2865d42c78a912 Larry Finger ed5d2eaf5f5d59 Nishka Dasgupta 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 534c4acd1d4594 James 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger fdfbf7890dcac9 James 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 09b080f73a4191 Vijai Kumar K 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger a77a40cf8b42b3 Bhagyashri Dighole a77a40cf8b42b3 Bhagyashri Dighole bd4fcdaddc8d8d Souptick Joarder bd4fcdaddc8d8d Souptick Joarder bd4fcdaddc8d8d Souptick Joarder ed5d2eaf5f5d59 Nishka Dasgupta bd4fcdaddc8d8d Souptick Joarder 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 534c4acd1d4594 James 45afa5637b85d7 Aiman Najjar 45afa5637b85d7 Aiman Najjar 9155c92463ecbb Bhumika Goyal ed5d2eaf5f5d59 Nishka Dasgupta 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger a4898e78c368fb Nishka Dasgupta ed5d2eaf5f5d59 Nishka Dasgupta fdfbf7890dcac9 James 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 8810493fc54e75 Deepak Mishra 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger 1062aa9e99e6d9 Allen Pais ed5d2eaf5f5d59 Nishka Dasgupta 2865d42c78a912 Larry Finger 2865d42c78a912 Larry Finger
---
0-DAY CI Kernel Test Attachment: Description: application/gzip Alexander Duyck: "Re: [igb] netconsole triggers warning in netpoll_poll_dev" message: kernel test robot: "Re: [PATCH v3] media: venus : hfi: add venus image info into smem" to: kernel test robot: "Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h" sorted by: [ date ] [ thread ] [ subject ] [ author ] patch! Yet something to improve:
on staging/staging-testing]
href="https://github.com/0day-ci/linux/commits/Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925">https://github.com/0day-ci/linux/commits/Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925
href="https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git">https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git e91cafdf3c18b927e61eb4ee18e4865b8485f24f
(attached as .config)
9.3.0-22) 9.3.0
href="https://github.com/0day-ci/linux/commit/9f510deed38aa66173f9ffc8f21c7d61d96f583f">https://github.com/0day-ci/linux/commit/9f510deed38aa66173f9ffc8f21c7d61d96f583f
rel="nofollow" href="https://github.com/0day-ci/linux">https://github.com/0day-ci/linux
--no-tags linux-review Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925
9f510deed38aa66173f9ffc8f21c7d61d96f583f
attached .config to linux build tree
kindly add following tag as appropriate
test robot <lkp@xxxxxxxxx>
prefixed by >>):
from include/linux/interrupt.h:15,
from drivers/staging/rtl8712/osdep_service.h:22,
from drivers/staging/rtl8712/rtl871x_xmit.c:19:
rtl871x_xmit.c: In function '_r8712_init_xmit_priv':
/rtl8712/rtl871x_xmit.c:144:41: error: 'r8712_SetFilter' undeclared (first use in this function); did you mean 'r8712_set_filter'?
padapter->wk_filter_rx_ff0, r8712_SetFilter);
^~~~~~~~~~~~~~~
note: in definition of macro '__INIT_WORK'
= (_func); \
rtl871x_xmit.c:144:2: note: in expansion of macro 'INIT_WORK'
padapter->wk_filter_rx_ff0, r8712_SetFilter);
rtl871x_xmit.c:144:41: note: each undeclared identifier is reported only once for each function it appears in
padapter->wk_filter_rx_ff0, r8712_SetFilter);
^~~~~~~~~~~~~~~
note: in definition of macro '__INIT_WORK'
= (_func); \
rtl871x_xmit.c:144:2: note: in expansion of macro 'INIT_WORK'
padapter->wk_filter_rx_ff0, r8712_SetFilter);
l8712/rtl871x_xmit.c
2010-08-20 18
2010-08-20 @19 #include "osdep_service.h"
2010-08-20 20 #include "drv_types.h"
2010-08-20 21 #include "wifi.h"
2010-08-20 22 #include "osdep_intf.h"
2010-08-20 23 #include "usb_ops.h"
2010-08-20 24
2010-08-20 25
2010-08-20 26 static const u8 P802_1H_OUI[P80211_OUI_LEN] = {0x00, 0x00, 0xf8};
2010-08-20 27 static const u8 RFC1042_OUI[P80211_OUI_LEN] = {0x00, 0x00, 0x00};
2010-08-20 28 static void init_hwxmits(struct hw_xmit *phwxmit, sint entry);
2010-08-20 29 static void alloc_hwxmits(struct _adapter *padapter);
2010-08-20 30 static void free_hwxmits(struct _adapter *padapter);
2010-08-20 31
2010-08-20 32 static void _init_txservq(struct tx_servq *ptxservq)
2010-08-20 33 {
A Shackleford 2014-06-24 34 INIT_LIST_HEAD(&ptxservq->tx_pending);
2010-08-20 35 _init_queue(&ptxservq->sta_pending);
2010-08-20 36 ptxservq->qcnt = 0;
2010-08-20 37 }
2010-08-20 38
2010-08-20 39 void _r8712_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv)
2010-08-20 40 {
2010-08-20 41 memset((unsigned char *)psta_xmitpriv, 0,
2010-08-20 42 sizeof(struct sta_xmit_priv));
2010-08-20 43 spin_lock_init(&psta_xmitpriv->lock);
2010-08-20 44 _init_txservq(&psta_xmitpriv->be_q);
2010-08-20 45 _init_txservq(&psta_xmitpriv->bk_q);
2010-08-20 46 _init_txservq(&psta_xmitpriv->vi_q);
2010-08-20 47 _init_txservq(&psta_xmitpriv->vo_q);
A Shackleford 2014-06-24 48 INIT_LIST_HEAD(&psta_xmitpriv->legacy_dz);
A Shackleford 2014-06-24 49 INIT_LIST_HEAD(&psta_xmitpriv->apsd);
2010-08-20 50 }
2010-08-20 51
2019-08-09 52 int _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv,
2010-08-20 53 struct _adapter *padapter)
2010-08-20 54 {
2010-08-20 55 sint i;
2010-08-20 56 struct xmit_buf *pxmitbuf;
2010-08-20 57 struct xmit_frame *pxframe;
2010-08-20 58
2010-08-20 59 memset((unsigned char *)pxmitpriv, 0, sizeof(struct xmit_priv));
2010-08-20 60 spin_lock_init(&pxmitpriv->lock);
2010-08-20 61 /*
2016-11-20 62 *Please insert all the queue initialization using _init_queue below
2010-08-20 63 */
2010-08-20 64 pxmitpriv->adapter = padapter;
2010-08-20 65 _init_queue(&pxmitpriv->be_pending);
2010-08-20 66 _init_queue(&pxmitpriv->bk_pending);
2010-08-20 67 _init_queue(&pxmitpriv->vi_pending);
2010-08-20 68 _init_queue(&pxmitpriv->vo_pending);
2010-08-20 69 _init_queue(&pxmitpriv->bm_pending);
2010-08-20 70 _init_queue(&pxmitpriv->legacy_dz_queue);
2010-08-20 71 _init_queue(&pxmitpriv->apsd_queue);
2010-08-20 72 _init_queue(&pxmitpriv->free_xmit_queue);
2010-08-20 73 /*
2020-03-29 74 * Please allocate memory with sz = (struct xmit_frame) * NR_XMITFRAME,
2016-11-20 75 * and initialize free_xmit_frame below.
2016-11-20 76 * Please also apply free_txobj to link_up all the xmit_frames...
2010-08-20 77 */
2019-03-12 78 pxmitpriv->pallocated_frame_buf =
2020-03-29 79 kmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4,
2020-03-29 80 GFP_ATOMIC);
2016-02-24 81 if (!pxmitpriv->pallocated_frame_buf) {
2010-08-20 82 pxmitpriv->pxmit_frame_buf = NULL;
2019-08-09 83 return -ENOMEM;
2010-08-20 84 }
2010-08-20 85 pxmitpriv->pxmit_frame_buf = pxmitpriv->pallocated_frame_buf + 4 -
2010-08-20 86 ((addr_t) (pxmitpriv->pallocated_frame_buf) & 3);
2010-08-20 87 pxframe = (struct xmit_frame *) pxmitpriv->pxmit_frame_buf;
2010-08-20 88 for (i = 0; i < NR_XMITFRAME; i++) {
A Shackleford 2014-06-24 89 INIT_LIST_HEAD(&(pxframe->list));
2010-08-20 90 pxframe->padapter = padapter;
2010-08-20 91 pxframe->frame_tag = DATA_FRAMETAG;
2010-08-20 92 pxframe->pkt = NULL;
2010-08-20 93 pxframe->buf_addr = NULL;
2010-08-20 94 pxframe->pxmitbuf = NULL;
A Shackleford 2014-06-24 95 list_add_tail(&(pxframe->list),
2010-08-20 96 &(pxmitpriv->free_xmit_queue.queue));
2010-08-20 97 pxframe++;
2010-08-20 98 }
2010-08-20 99 pxmitpriv->free_xmitframe_cnt = NR_XMITFRAME;
2010-08-20 100 /*
2016-11-20 101 * init xmit hw_txqueue
2010-08-20 102 */
2010-08-20 103 _r8712_init_hw_txqueue(&pxmitpriv->be_txqueue, BE_QUEUE_INX);
2010-08-20 104 _r8712_init_hw_txqueue(&pxmitpriv->bk_txqueue, BK_QUEUE_INX);
2010-08-20 105 _r8712_init_hw_txqueue(&pxmitpriv->vi_txqueue, VI_QUEUE_INX);
2010-08-20 106 _r8712_init_hw_txqueue(&pxmitpriv->vo_txqueue, VO_QUEUE_INX);
2010-08-20 107 _r8712_init_hw_txqueue(&pxmitpriv->bmc_txqueue, BMC_QUEUE_INX);
2010-08-20 108 pxmitpriv->frag_len = MAX_FRAG_THRESHOLD;
2010-08-20 109 pxmitpriv->txirp_cnt = 1;
2010-08-20 110 /*per AC pending irp*/
2010-08-20 111 pxmitpriv->beq_cnt = 0;
2010-08-20 112 pxmitpriv->bkq_cnt = 0;
2010-08-20 113 pxmitpriv->viq_cnt = 0;
2010-08-20 114 pxmitpriv->voq_cnt = 0;
2010-08-20 115 /*init xmit_buf*/
2010-08-20 116 _init_queue(&pxmitpriv->free_xmitbuf_queue);
2010-08-20 117 _init_queue(&pxmitpriv->pending_xmitbuf_queue);
2019-03-12 118 pxmitpriv->pallocated_xmitbuf =
2019-03-12 119 kmalloc(NR_XMITBUFF * sizeof(struct xmit_buf) + 4, GFP_ATOMIC);
2016-10-31 120 if (!pxmitpriv->pallocated_xmitbuf) {
2016-10-31 121 kfree(pxmitpriv->pallocated_frame_buf);
2016-10-31 122 pxmitpriv->pallocated_frame_buf = NULL;
2019-08-09 123 return -ENOMEM;
2016-10-31 124 }
2010-08-20 125 pxmitpriv->pxmitbuf = pxmitpriv->pallocated_xmitbuf + 4 -
2010-08-20 126 ((addr_t)(pxmitpriv->pallocated_xmitbuf) & 3);
2010-08-20 127 pxmitbuf = (struct xmit_buf *)pxmitpriv->pxmitbuf;
2010-08-20 128 for (i = 0; i < NR_XMITBUFF; i++) {
A Shackleford 2014-06-24 129 INIT_LIST_HEAD(&pxmitbuf->list);
2020-03-29 130 pxmitbuf->pallocated_buf =
2020-03-29 131 kmalloc(MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, GFP_ATOMIC);
2016-02-24 132 if (!pxmitbuf->pallocated_buf)
2019-08-09 133 return -ENOMEM;
2010-08-20 134 pxmitbuf->pbuf = pxmitbuf->pallocated_buf + XMITBUF_ALIGN_SZ -
2010-08-20 135 ((addr_t) (pxmitbuf->pallocated_buf) &
2010-08-20 136 (XMITBUF_ALIGN_SZ - 1));
2019-06-26 137 if (r8712_xmit_resource_alloc(padapter, pxmitbuf))
2019-08-09 138 return -ENOMEM;
A Shackleford 2014-06-24 139 list_add_tail(&pxmitbuf->list,
2010-08-20 140 &(pxmitpriv->free_xmitbuf_queue.queue));
2010-08-20 141 pxmitbuf++;
2010-08-20 142 }
2010-08-20 143 pxmitpriv->free_xmitbuf_cnt = NR_XMITBUFF;
2019-06-12 @144 INIT_WORK(&padapter->wk_filter_rx_ff0, r8712_SetFilter);
2010-08-20 145 alloc_hwxmits(padapter);
2010-08-20 146 init_hwxmits(pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry);
2020-09-16 147 tasklet_setup(&pxmitpriv->xmit_tasklet, r8712_xmit_bh);
2019-08-09 148 return 0;
2010-08-20 149 }
2010-08-20 150
Service, Intel Corporation
href="https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Alexander Duyck: "Re: [igb] netconsole triggers warning in netpoll_poll_dev"
Previous message: kernel test robot: "Re: [PATCH v3] media: venus : hfi: add venus image info into smem"
In reply to: kernel test robot: "Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]