Re: [PATCH] ASoC: simple-card: fix possible uninitialized single_cpu local variable

[Sameer Pujar]

On 4/7/2021 2:50 PM, Krzysztof Kozlowski wrote:
> The 'single_cpu' local variable is assigned by asoc_simple_parse_dai()
> and later used in a asoc_simple_canonicalize_cpu() call, assuming the
> entire function did not exit on errors.
>
> However the first function returns 0 if passed device_node is NULL,
> thus leaving the variable uninitialized and reporting success.
>
> Addresses-Coverity: Uninitialized scalar variable
> Fixes: 8f7f298a3337 ("ASoC: simple-card-utils: separate asoc_simple_card_parse_dai()")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> ---
>   sound/soc/generic/audio-graph-card.c | 2 +-
>   sound/soc/generic/simple-card.c      | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Sameer Pujar <spujar@xxxxxxxxxx>