Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h

From: Jani Nikula
Date: Wed Apr 07 2021 - 08:46:49 EST


On Wed, 07 Apr 2021, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> There is no need to carry on entire kernel.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

That's hardly drm/i915 specific!

Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

But who's going to pick it up and, hopefully, change the subject prefix
to ascii85 or something?

> ---
> include/linux/ascii85.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h
> index 4cc40201273e..83ad775ad0aa 100644
> --- a/include/linux/ascii85.h
> +++ b/include/linux/ascii85.h
> @@ -8,7 +8,8 @@
> #ifndef _ASCII85_H_
> #define _ASCII85_H_
>
> -#include <linux/kernel.h>
> +#include <linux/math.h>
> +#include <linux/types.h>
>
> #define ASCII85_BUFSZ 6

--
Jani Nikula, Intel Open Source Graphics Center