Re: [PATCH] irqchip/gic-v3: fix OF_BAD_ADDR error handling

From: Marc Zyngier
Date: Wed Apr 07 2021 - 08:32:05 EST


On Tue, 23 Mar 2021 14:18:35 +0100, Arnd Bergmann wrote:
> When building with extra warnings enabled, clang points out a
> mistake in the error handling:
>
> drivers/irqchip/irq-gic-v3-mbi.c:306:21: error: result of comparison of constant 18446744073709551615 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
> if (mbi_phys_base == OF_BAD_ADDR) {
>
> Truncate the constant to the same type as the variable it gets compared
> to, to shut make the check work and void the warning.

Applied to irq/irqchip-next, thanks!

[1/1] irqchip/gic-v3: fix OF_BAD_ADDR error handling
commit: 8e13d96670a4c050d4883e6743a9e9858e5cfe10

Cheers,

M.
--
Without deviation from the norm, progress is not possible.