Re: [PATCH v2 06/10] irqchip: Add driver for WPCM450 interrupt controller

From: Jonathan Neuschäfer
Date: Wed Apr 07 2021 - 08:07:31 EST


On Wed, Apr 07, 2021 at 12:11:21PM +0100, Marc Zyngier wrote:
> On Tue, 06 Apr 2021 13:09:17 +0100,
> Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> wrote:
...
> > diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
> > index 658c8efb4ca14..a71cf1d189ae5 100644
> > --- a/arch/arm/mach-npcm/Kconfig
> > +++ b/arch/arm/mach-npcm/Kconfig
> > @@ -10,6 +10,7 @@ config ARCH_WPCM450
> > bool "Support for WPCM450 BMC (Hermon)"
> > depends on ARCH_MULTI_V5
> > select CPU_ARM926T
> > + select WPCM450_AIC
> > select NPCM7XX_TIMER
> > help
> > General support for WPCM450 BMC (Hermon).
>
> I can't take this patch with this particular hunk, as I don't have
> this file in my tree. I can either drop this line, or delay the
> merging of this patch to a later point in time.

Hmm, indeed. Please apply the patch without this hunk. I'll reintroduce
it in another patch.

>
> The driver otherwise looks ready.

Good.

Thanks,
Jonathan

Attachment: signature.asc
Description: PGP signature