Re: [PATCH v8 7/9] vfio/mdev: Add iommu related member in mdev_device

From: Jason Gunthorpe
Date: Wed Apr 07 2021 - 07:34:52 EST


On Wed, Apr 07, 2021 at 09:58:05AM +0800, Lu Baolu wrote:

> I've ever tried to implement a bus iommu_ops for mdev devices.
>
> https://lore.kernel.org/lkml/20201030045809.957927-1-baolu.lu@xxxxxxxxxxxxxxx/
>
> Any comments?

You still have the symbol_get, so something continues to be wrong with
that series:

+ mdev_bus = symbol_get(mdev_bus_type);
+ if (mdev_bus) {
+ if (bus == mdev_bus && !iommu_present(bus)) {
+ symbol_put(mdev_bus_type);

Jason