Re: [PATCH 03/11] block: mtip32xx: mtip32xx: Mark debugging variable 'start' as __maybe_unused

From: Lee Jones
Date: Wed Apr 07 2021 - 04:01:02 EST


On Tue, 06 Apr 2021, Bart Van Assche wrote:

> On 3/12/21 2:55 AM, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/block/mtip32xx/mtip32xx.c: In function ‘mtip_standby_immediate’:
> > drivers/block/mtip32xx/mtip32xx.c:1216:16: warning: variable ‘start’ set but not used [-Wunused-but-set-variable]
>
> Has it been verified that the compiler is wrong, or in other words that
> this patch does not suppress a useful warning?

Neither is true.

'start' is used, but only when debug is enabled.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog